-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent flickering when selecting files in staged/unstaged FileStatusList #7267
prevent flickering when selecting files in staged/unstaged FileStatusList #7267
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7267 +/- ##
=========================================
- Coverage 48.01% 48% -0.01%
=========================================
Files 747 748 +1
Lines 54807 54819 +12
Branches 7146 7148 +2
=========================================
+ Hits 26316 26318 +2
- Misses 27081 27084 +3
- Partials 1410 1417 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To confirm - if use tab to cycle between controls, we don't get flickering, do we? |
76437bf
to
acf2fe0
Compare
{ | ||
if (m.Msg == NativeConstants.WM_MOUSEACTIVATE) | ||
{ | ||
_mouseEntered = !Focused; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed this from simply true
to !Focused
as if you'd click on a list a second time this would get set to true
and would remain so as Enter
would not fire and this would not get reset to False
.
Found this after some more manual testing.
We don't with this fix and we didn't as when you'd tab around the first item gets selected so even if it used to flicker technically it wasn't visible as it'd flicker between the same item. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm.
All your comments have been addressed, @RussKie.
Fixes #7266
Proposed changes
Entering
the control by keyboard as when using the mouse you either click on specific item to select it or on an empty space to deselect everythingEnter
event toFileStatusList
which would provide extra details as to how control was enteredTest methodology